Date: Wed, 7 Nov 2012 01:15:31 -0500 (EST)
From: David Airlie <airlied@redhat.com>
To: Huang Ying <ying.huang@intel.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>, "Rafael J. Wysocki" <rjw@sisk.pl>
Message-ID: <890104457.2285480.1352268931077.JavaMail.root@redhat.com>
In-Reply-To: <1352267925.7176.3.camel@yhuang-dev>
Subject: Re: [PATCH] pci/runtime-pm: respect devices autosuspend timeout on
 config access
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1411
Lines: 37


> > 
> > Cc: Huang Ying <ying.huang@intel.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Rafael J. Wysocki <rjw@sisk.pl>
> > Signed-off-by: Dave Airlie <airlied@redhat.com>
> > ---
> >  drivers/pci/pci-sysfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> > index 02d107b..12d3d52 100644
> > --- a/drivers/pci/pci-sysfs.c
> > +++ b/drivers/pci/pci-sysfs.c
> > @@ -487,7 +487,7 @@ pci_config_pm_runtime_put(struct pci_dev *pdev)
> >  	struct device *dev = &pdev->dev;
> >  	struct device *parent = dev->parent;
> >  
> > -	pm_runtime_put(dev);
> > +	pm_runtime_put_autosuspend(dev);
> >  	if (parent)
> >  		pm_runtime_put_sync(parent);
> >  }
> 
> I think you do not need that.  You can implement timeout
> in .runtime_idle callback of the driver.

If I understand what you are suggesting, I should setup some kinda of timer callback to later call suspend, but that seems pointless for me if we have the autosuspend mechanism in place.

Won't I end up racing my timer against other pm stuff? I'm not really runtime pm expert so maybe I'm just missing something.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/