Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753653Ab2KGJkT (ORCPT ); Wed, 7 Nov 2012 04:40:19 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:51804 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106Ab2KGJkQ (ORCPT ); Wed, 7 Nov 2012 04:40:16 -0500 Date: Wed, 7 Nov 2012 09:40:06 +0000 From: Andy Whitcroft To: Andrew Morton Cc: Joe Perches , Adil Mujeeb , Pavel Machek , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 3/3] checkpatch: Emit an warning when floating point values are used Message-ID: <20121107094006.GE3066@dm> References: <359a78054bc0dfaedede95222781b4177d3c33ce.1351736873.git.joe@perches.com> <20121106153625.c48ba1f1.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121106153625.c48ba1f1.akpm@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 40 On Tue, Nov 06, 2012 at 03:36:25PM -0800, Andrew Morton wrote: > On Thu, 1 Nov 2012 00:12:18 -0700 > Joe Perches wrote: > > > Linux kernel doesn't like floating point, say so. > > > > ... > > > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -2332,6 +2332,13 @@ sub process { > > "do not add new typedefs\n" . $herecurr); > > } > > > > +# check for floating point constants > > + > > + if ($line =~ /\b$Float\b/) { > > + WARN("KERNEL_FLOAT", > > + "Floating point is not supported in linux kernel source\n" . $herecurr); > > + } > > + > > # * goes on variable not on type > > # (char*[ const]) > > while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) { > > The earlier review comments were not addressed. > > In particular, I don't see a problem with people doing > > int foo = 1.1 * 2.2; I thought there was also now a way to enable floats in kernel space and some use thereof. -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/