Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932098Ab2KGMYM (ORCPT ); Wed, 7 Nov 2012 07:24:12 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:44666 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745Ab2KGMYL (ORCPT ); Wed, 7 Nov 2012 07:24:11 -0500 MIME-Version: 1.0 In-Reply-To: <1352283494-31200-1-git-send-email-gaowanlong@cn.fujitsu.com> References: <1352283494-31200-1-git-send-email-gaowanlong@cn.fujitsu.com> From: Asias He Date: Wed, 7 Nov 2012 20:23:28 +0800 Message-ID: Subject: Re: [PATCH 0/5] virtio-scsi: create a separate workqueue To: Wanlong Gao Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , Paolo Bonzini , Rusty Russell , linux-scsi@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2095 Lines: 63 On Wed, Nov 7, 2012 at 6:18 PM, Wanlong Gao wrote: > patch 1-3,5 are some cleanups. > patch 4: create a separate work queue for virtio-scsi > to improve the performance, I tested with tmpfs backed > disk, the config file is like below, > [global] > bsrange=4k-64k > ioengine=libaio > direct=1 > iodepth=4 > loops=10 > size=64M > > Before: > Disk stats (read/write): > sda: ios=6547/5275, merge=37/39, ticks=3144/2645, in_queue=5780, util=81.62% > sdb: ios=6542/5277, merge=54/59, ticks=3234/3143, in_queue=6364, util=84.50% > sdc: ios=6532/5244, merge=65/62, ticks=3440/3076, in_queue=6505, util=86.83% The result is about the disk stat. Can you please post the iops and the bw instead? > After: > Disk stats (read/write): > sda: ios=6349/5318, merge=77/89, ticks=4820/3169, in_queue=7991, util=90.62% > sdb: ios=6364/5358, merge=39/53, ticks=3810/2816, in_queue=6615, util=84.63% > sdc: ios=6458/5352, merge=74/47, ticks=4425/3048, in_queue=7459, util=88.41% > > > Wanlong Gao (5): > virtio-scsi: remove the useless assignment > virtio-scsi: remove the needless variable gfp_mask > virtio-scsi: use pr_err instead of printk > virtio-scsi: create a separate work queue for virtio-scsi > virtio-scsi: tidy up the goto label in init() > > > > Cc: James E.J. Bottomley > Cc: Paolo Bonzini > Cc: Rusty Russell > Cc: linux-scsi@vger.kernel.org > Cc: kvm@vger.kernel.org > drivers/scsi/virtio_scsi.c | 43 +++++++++++++++++++++++-------------------- > 1 file changed, 23 insertions(+), 20 deletions(-) > > -- > 1.8.0 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Asias He -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/