Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581Ab2KGPWB (ORCPT ); Wed, 7 Nov 2012 10:22:01 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:52663 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432Ab2KGPV6 convert rfc822-to-8bit (ORCPT ); Wed, 7 Nov 2012 10:21:58 -0500 From: "Philip, Avinash" To: "Bedia, Vaibhav" , "thierry.reding@avionic-design.de" , "paul@pwsan.com" , "tony@atomide.com" , "linux@arm.linux.org.uk" , "Cousson, Benoit" CC: "linux-doc@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "Nori, Sekhar" , "linux-kernel@vger.kernel.org" , "Hiremath, Vaibhav" , "Hebbar, Gururaja" , "AnilKumar, Chimata" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 6/8] pwm: pwm-tiehrpwm: Adding TBCLK gating support. Thread-Topic: [PATCH 6/8] pwm: pwm-tiehrpwm: Adding TBCLK gating support. Thread-Index: AQHNuzgji9uGjRQDykmHbTJ8YyrhrpfcAi+AgABmL5A= Date: Wed, 7 Nov 2012 15:20:30 +0000 Deferred-Delivery: Wed, 7 Nov 2012 15:20:00 +0000 Message-ID: <518397C60809E147AF5323E0420B992E3E9DE3AA@DBDE01.ent.ti.com> References: <1352106749-9437-1-git-send-email-avinashphilip@ti.com> <1352106749-9437-7-git-send-email-avinashphilip@ti.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1070 Lines: 39 On Tue, Nov 06, 2012 at 12:16:13, Bedia, Vaibhav wrote: > On Mon, Nov 05, 2012 at 14:42:27, Philip, Avinash wrote: > [...] > > > + /* Some platforms require explicit tbclk gating */ > > + if (of_property_read_bool(pdev->dev.of_node, "tbclkgating")) { > > + pc->tbclk = clk_get(&pdev->dev, "tbclk"); > > + if (IS_ERR(pc->tbclk)) { > > + dev_err(&pdev->dev, "Could not get EHRPWM TBCLK\n"); > > + return PTR_ERR(pc->tbclk); > > + } > > + } > > + > > + /* Enable tbclk & leave */ > > + if (pc->tbclk) > > + clk_enable(pc->tbclk); > > + > > Here also why are you leaving this clock always running? This is an additional clock gating for EHRPWM functional clock from control module. The enabling of this clock to pwm_enable & disabling to pwm_disable. I will correct it. Thanks Avinash > > Regards, > Vaibhav > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/