Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753034Ab2KGQ3S (ORCPT ); Wed, 7 Nov 2012 11:29:18 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:64286 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024Ab2KGQ3Q (ORCPT ); Wed, 7 Nov 2012 11:29:16 -0500 Subject: Re: [PATCH] tcp: Replace infinite loop on recvmsg bug with proper crashusers From: Eric Dumazet To: Dave Jones Cc: Julius Werner , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Patrick McHardy , Hideaki YOSHIFUJI , James Morris , Alexey Kuznetsov , "David S. Miller" , Sameer Nanda , Mandeep Singh Baines , Eric Dumazet In-Reply-To: <20121107155434.GA17677@redhat.com> References: <1352247335-10396-1-git-send-email-jwerner@chromium.org> <20121107013907.GA31185@redhat.com> <20121107155434.GA17677@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 07 Nov 2012 08:29:12 -0800 Message-ID: <1352305752.3140.4449.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 27 On Wed, 2012-11-07 at 10:54 -0500, Dave Jones wrote: > It sounds more appropriate to me, instead of silently wedging the box. > At least with that approach we have a chance of finding out what happened. Its quite the opposite. If bug is still there 6 months after the commits that broke the drivers, (making an old bug visible) that means that people never realized the bug was there. I understand a distro maintainer has its own choices, but for upstream kernel we want to have early reports. This bug is fatal and a security issue. BUG() is appropriate. If the driver cant be fixed, it should be marked broken. So I personally NACKed patch to hide the bug, trying to be friendly to the user. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/