Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752498Ab2KGT4N (ORCPT ); Wed, 7 Nov 2012 14:56:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53167 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149Ab2KGT4M (ORCPT ); Wed, 7 Nov 2012 14:56:12 -0500 Date: Wed, 7 Nov 2012 11:56:10 -0800 From: Andrew Morton To: Rafael Aquini Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , "Michael S. Tsirkin" , Rik van Riel , Mel Gorman , Andi Kleen , Konrad Rzeszutek Wilk , Minchan Kim , Peter Zijlstra , "Paul E. McKenney" Subject: Re: [PATCH v11 1/7] mm: adjust address_space_operations.migratepage() return code Message-Id: <20121107115610.c0cb650c.akpm@linux-foundation.org> In-Reply-To: <74bc30697313206e1225f6fc658bc5952b588dcc.1352256085.git.aquini@redhat.com> References: <74bc30697313206e1225f6fc658bc5952b588dcc.1352256085.git.aquini@redhat.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 26 On Wed, 7 Nov 2012 01:05:48 -0200 Rafael Aquini wrote: > This patch introduces MIGRATEPAGE_SUCCESS as the default return code > for address_space_operations.migratepage() method and documents the > expected return code for the same method in failure cases. I hit a large number of rejects applying this against linux-next. Due to the increasingly irritating sched/numa code in there. I attempted to fix it up and also converted some (but not all) of the implicit tests of `rc' against zero. Please check the result very carefully - more changes will be needed. All those - if (rc) + if (rc != MIGRATEPAGE_SUCCESS) changes are a pain. Perhaps we shouldn't bother. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/