Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753204Ab2KGVCL (ORCPT ); Wed, 7 Nov 2012 16:02:11 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53650 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074Ab2KGVCJ (ORCPT ); Wed, 7 Nov 2012 16:02:09 -0500 Date: Wed, 7 Nov 2012 13:02:07 -0800 From: Andrew Morton To: Rafael Aquini Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , "Michael S. Tsirkin" , Rik van Riel , Mel Gorman , Andi Kleen , Konrad Rzeszutek Wilk , Minchan Kim , Peter Zijlstra , "Paul E. McKenney" Subject: Re: [PATCH v11 3/7] mm: introduce a common interface for balloon pages mobility Message-Id: <20121107130207.214f16ea.akpm@linux-foundation.org> In-Reply-To: <4ea10ef1eb1544e12524c8ca7df20cf621395463.1352256087.git.aquini@redhat.com> References: <4ea10ef1eb1544e12524c8ca7df20cf621395463.1352256087.git.aquini@redhat.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1833 Lines: 46 On Wed, 7 Nov 2012 01:05:50 -0200 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > transparent huge pages that could be used by the guest workload. > > This patch introduces a common interface to help a balloon driver on > making its page set movable to compaction, and thus allowing the system > to better leverage the compation efforts on memory defragmentation. mm/migrate.c: In function 'unmap_and_move': mm/migrate.c:899: error: 'COMPACTBALLOONRELEASED' undeclared (first use in this function) mm/migrate.c:899: error: (Each undeclared identifier is reported only once mm/migrate.c:899: error: for each function it appears in.) You've been bad - you didn't test with your feature disabled. Please do that. And not just compilation testing. We can fix this one with a sucky macro. I think that's better than unconditionally defining the enums. --- a/include/linux/balloon_compaction.h~mm-introduce-a-common-interface-for-balloon-pages-mobility-fix +++ a/include/linux/balloon_compaction.h @@ -207,10 +207,8 @@ static inline gfp_t balloon_mapping_gfp_ return GFP_HIGHUSER; } -static inline void balloon_event_count(enum vm_event_item item) -{ - return; -} +/* A macro, to avoid generating references to the undefined COMPACTBALLOON* */ +#define balloon_event_count(item) do { } while (0) static inline bool balloon_compaction_check(void) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/