Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754882Ab2KHHKa (ORCPT ); Thu, 8 Nov 2012 02:10:30 -0500 Received: from mail.free-electrons.com ([88.190.12.23]:49330 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192Ab2KHHK3 (ORCPT ); Thu, 8 Nov 2012 02:10:29 -0500 Date: Thu, 8 Nov 2012 08:10:19 +0100 From: Thomas Petazzoni To: Axel Lin Cc: Grant Likely , Linus Walleij , Sebastian Hesselbarth , Andrew Lunn , linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio: mvebu: Set free callback for gpio_chip Message-ID: <20121108081019.4e133962@skate> In-Reply-To: <1352341649.19098.1.camel@phoenix> References: <1352341649.19098.1.camel@phoenix> Organization: Free Electrons X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 23 On Thu, 08 Nov 2012 10:27:29 +0800, Axel Lin wrote: > We call pinctrl_request_gpio() in request callback, thus we need to call > pinctrl_free_gpio() in free callback. > > Both mvebu_gpio_request() and mvebu_gpio_free() are not referenced outside of > this file, make them static. Indeed, thanks. > Signed-off-by: Axel Lin Acked-by: Thomas Petazzoni -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/