Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755182Ab2KHLwO (ORCPT ); Thu, 8 Nov 2012 06:52:14 -0500 Received: from casper.infradead.org ([85.118.1.10]:45055 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493Ab2KHLwL (ORCPT ); Thu, 8 Nov 2012 06:52:11 -0500 Message-ID: <509B9CC2.4070502@kernel.dk> Date: Thu, 08 Nov 2012 12:51:30 +0100 From: Jens Axboe MIME-Version: 1.0 To: Wei Yongjun CC: smani@micron.com, yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mtip32xx: fix potential NULL pointer dereference in mtip_timeout_function() References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 612 Lines: 19 On 2012-11-08 10:35, Wei Yongjun wrote: > From: Wei Yongjun > > The dereference to port should be moved below the NULL test. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) Thanks, it definitely doesn't make sense to check for !port after having dereferenced it. Applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/