Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755530Ab2KHMyl (ORCPT ); Thu, 8 Nov 2012 07:54:41 -0500 Received: from mail-ea0-f174.google.com ([209.85.215.174]:45380 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755497Ab2KHMyk (ORCPT ); Thu, 8 Nov 2012 07:54:40 -0500 MIME-Version: 1.0 In-Reply-To: References: <1352215014-30305-1-git-send-email-linus.walleij@stericsson.com> Date: Thu, 8 Nov 2012 13:54:39 +0100 Message-ID: Subject: Re: [PATCH 3/5] gpiolib: remove duplicate pin range code From: Linus Walleij To: viresh kumar Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shiraz Hashim , Stephen Warren , Anmar Oueja , Grant Likely Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 31 On Wed, Nov 7, 2012 at 6:14 AM, viresh kumar wrote: > On Tue, Nov 6, 2012 at 8:46 PM, Linus Walleij > wrote: >> From: Linus Walleij >> >> Commit 69e1601bca88809dc118abd1becb02c15a02ec71 >> "gpiolib: provide provision to register pin ranges" >> >> Introduced both of_gpiochip_remove_pin_range() and >> gpiochip_remove_pin_ranges(). But the contents are exactly >> the same so remove the OF one and rely on the range deletion >> in the core. >> >> Signed-off-by: Linus Walleij > > I can't believe that i did this :( Don't worry, it's impossible to get these things right. I am trying to fix it properly here and just introduce new bugs for every fix I try to make. Maybe I'll soon have something that actually doesn't break x86... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/