Date: Thu, 8 Nov 2012 09:52:43 -0500 (EST)
From: Tomas Hozza <thozza@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        devel@linuxdriverproject.org, apw@canonical.com, jasowang@redhat.com,
        kys@microsoft.com
Message-ID: <999858348.7901147.1352386363812.JavaMail.root@redhat.com>
In-Reply-To: <20121108141925.GA20083@aepfle.de>
Subject: Re: [PATCH] Tools: hv: Fix for long file names from readdir
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 606
Lines: 18

> > -        char dev_id[256];
> > +        char dev_id[512];
> 
> Shouldnt that be PATH_MAX or similar?

dirent->d_name should be PATH_MAX, but it is mostly 
not guaranteed. And then the dev_id is concatenated
with two strings so it can exceed 256 bytes.

After discussion with K. Y. Srinivasan I just doubled
the size and added size checks for sanity.

Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/