Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756243Ab2KHP6V (ORCPT ); Thu, 8 Nov 2012 10:58:21 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33889 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464Ab2KHP6T (ORCPT ); Thu, 8 Nov 2012 10:58:19 -0500 Date: Thu, 08 Nov 2012 16:58:17 +0100 Message-ID: From: Takashi Iwai To: Alan Stern Cc: Daniel Mack , Christof Meerwald , "Artem S. Tashkinov" , Kernel development list , USB list Subject: Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1359 Lines: 41 At Thu, 8 Nov 2012 10:55:50 -0500 (EST), Alan Stern wrote: > > On Thu, 8 Nov 2012, Takashi Iwai wrote: > > > At Thu, 08 Nov 2012 08:31:35 +0100, > > Daniel Mack wrote: > > (snip) > > > >> We can't simply stop both endpoints in the prepare callback. > > > > > > > > The new function doesn't stop the stream by itself but it just syncs > > > > if the stream is being stopped beforehand. So, it's safe to call it > > > > there. > > > > > > > > Maybe the name was confusing. It should have been like > > > > snd_usb_endpoint_sync_pending_stop() or such. > > > > > > Ah, right. I was errornously looking closer to Alan's patch but then > > > replied to yours. Alright then - thanks for explaining :) > > > > OK, thanks for checking. > > > > FWIW, below is the patch I applied now to for-linus branch. > > Renamed the function, added the comment and put NULL check to the > > function to simplify. > > Thanks for fixing this. Is your patch marked for -stable? Yes. I'm going to send a pull request to Linus tomorrow. > I have submitted a patch for ehci-hcd, so we should be all set. OK, thanks! Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/