Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756607Ab2KHSYb (ORCPT ); Thu, 8 Nov 2012 13:24:31 -0500 Received: from mailout39.mail01.mtsvc.net ([216.70.64.83]:39794 "EHLO n12.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756500Ab2KHSYa (ORCPT ); Thu, 8 Nov 2012 13:24:30 -0500 Message-ID: <1352399063.2309.6.camel@thor> Subject: Re: [PATCH 5/5] drivers: mfd: Fix resource request for [mem 0x00000000] From: Peter Hurley To: Aaron Sierra Cc: Peter Tyser , Samuel Ortiz , linux-kernel@vger.kernel.org Date: Thu, 08 Nov 2012 13:24:23 -0500 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.2.4-0build1 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Authenticated-User: 125194 peter@hurleysoftware.com X-MT-ID: 8fa290c2a27252aacf65dbc4a42f3ce3735fb2a4 X-MT-INTERNAL-ID: 8fa290c2a27252aacf65dbc4a42f3ce3735fb2a4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2648 Lines: 77 On Thu, 2012-11-08 at 11:04 -0600, Aaron Sierra wrote: > > The older southbridges supported by the lpc_ich driver do not > > provide memory-mapped space of the root complex. The driver > > correctly avoids computing the iomem address in this case, yet > > submits a zeroed resource request anyway (via mfd_add_devices()). > > > > Remove the iomem resource from the resource array submitted to the > > mfd core for the older southbridges. > > > > Peter, thanks for catching this. > > > + } else { > > + /* So don't register iomem for TCO ver 1 */ > > + --lpc_ich_cells[LPC_WDT].num_resources; > > My only complaint is that pre-decrementing num_resources isn't > necessary and doesn't match the other cases where num_resources is > decremented (post-decremented), like here: > > if (!base_addr) { > dev_err(&dev->dev, "I/O space for ACPI uninitialized\n"); > lpc_ich_cells[LPC_GPIO].num_resources--; > goto gpe0_done; > } Sorry, C++ force-of-habit. How's this instead? (please note, I also retitled the patch to refer to lpc_ich specifically) -- >8 -- Subject: [PATCH v2 5/5] mfd: lpc_ich: Fix resource request for [mem 0x00000000] The older southbridges supported by the lpc_ich driver do not provide memory-mapped space of the root complex. The driver correctly avoids computing the iomem address in this case, yet submits a zeroed resource request anyway (via mfd_add_devices()). Remove the iomem resource from the resource array submitted to the mfd core for the older southbridges. Cc: Aaron Sierra Cc: Peter Tyser Cc: Samuel Ortiz Signed-off-by: Peter Hurley --- v2: post-decrement to match existing style retitle patch subject drivers/mfd/lpc_ich.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c index a22544f..f507c09 100644 --- a/drivers/mfd/lpc_ich.c +++ b/drivers/mfd/lpc_ich.c @@ -842,6 +842,9 @@ static int __devinit lpc_ich_init_wdt(struct pci_dev *dev, res = wdt_mem_res(ICH_RES_MEM_GCS); res->start = base_addr + ACPIBASE_GCS_OFF; res->end = base_addr + ACPIBASE_GCS_END; + } else { + /* So don't register iomem for TCO ver 1 */ + lpc_ich_cells[LPC_WDT].num_resources--; } lpc_ich_finalize_cell(&lpc_ich_cells[LPC_WDT], id); -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/