Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757547Ab2KIDaF (ORCPT ); Thu, 8 Nov 2012 22:30:05 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:39179 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757236Ab2KIDaC (ORCPT ); Thu, 8 Nov 2012 22:30:02 -0500 Subject: Re: [PATCH] tcp: Avoid infinite loop on recvmsg bug From: Eric Dumazet To: Julius Werner Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Patrick McHardy , Hideaki YOSHIFUJI , James Morris , Alexey Kuznetsov , "David S. Miller" , Dave Jones , Sameer Nanda , Mandeep Singh Baines In-Reply-To: References: <1352316791-16491-1-git-send-email-jwerner@chromium.org> <1352317219.5552.6.camel@edumazet-glaptop> <1352331192.2748.10.camel@edumazet-glaptop> <1352331754.2748.14.camel@edumazet-glaptop> Content-Type: text/plain; charset="UTF-8" Date: Thu, 08 Nov 2012 19:29:56 -0800 Message-ID: <1352431796.19779.536.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 26 On Wed, 2012-11-07 at 18:25 -0800, Julius Werner wrote: > > So you probably are fighting a bug we already fixed in upstream kernel. > > > > (commit c8628155ece363 "tcp: reduce out_of_order memory use" did not > > played well with cloned skbs.) > > > > This issue was already discussed on netdev in the past. > > Thanks for the hint. Unfortunately, we have not pulled c8628 into our > tree yet, so that's not it. Is there another point where the cloned > skb or the faked truesize might make it break? We have been running > this test with that hardware some 30 times in the last months and only > seen it once, so it cannot be that common. Update : Chrome OS current tree is based on 3.4 and really needed the patch : https://gerrit.chromium.org/gerrit/#/c/37666/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/