Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979Ab2KIHaK (ORCPT ); Fri, 9 Nov 2012 02:30:10 -0500 Received: from na3sys009aog111.obsmtp.com ([74.125.149.205]:36223 "EHLO na3sys009aog111.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751811Ab2KIHaI convert rfc822-to-8bit (ORCPT ); Fri, 9 Nov 2012 02:30:08 -0500 From: Xiangliang Yu To: Xi Wang , James Bottomley CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Thu, 8 Nov 2012 23:30:03 -0800 Subject: RE: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set() Thread-Topic: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set() Thread-Index: Ac28YRoPUWxNfPWcTYaq3VTXk0IWMQB6FgCw Message-ID: References: <1352145183-29355-1-git-send-email-xi.wang@gmail.com> <1352145183-29355-3-git-send-email-xi.wang@gmail.com> <1352203618.2529.22.camel@dabdike> <50997955.10000@gmail.com> In-Reply-To: <50997955.10000@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 30 > On 11/6/12 7:06 AM, James Bottomley wrote: > > > > Why is this necessary? As I read the reg set assignment code, it finds > > a free bit in the 64 bit register and uses that ... which can never be > > greater than 64 so there's no need for the check. > > This patch just tries to be more defensive for bit(reg_set) with a > broken reg_set value. I agree with you that it's not that necessary. Agree with James, and just need to do NOT operation one time > > > The other two look OK (probably redone as a single patch with a stable > > tag), but I'd like the input of the mvs people since it seems with the > > current code, we only use 32 bit regsets and probably hang if we go over > > that. The bug fix is either to enable the full 64 if it works, or > > possibly cap at 32 ... what works with all released devices? > > Thanks for reviewing. Yeah we'd better to wait for the input from > the mvs people. About patch 3, I check the ffz code and found it will check ~0 conditions. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/