Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753033Ab2KIHbf (ORCPT ); Fri, 9 Nov 2012 02:31:35 -0500 Received: from merlin.infradead.org ([205.233.59.134]:46163 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176Ab2KIHbe (ORCPT ); Fri, 9 Nov 2012 02:31:34 -0500 Message-ID: <509CB151.40207@kernel.dk> Date: Fri, 09 Nov 2012 08:31:29 +0100 From: Jens Axboe MIME-Version: 1.0 To: Ed Cashin CC: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] aoe: avoid running request handler on plugged queue References: In-Reply-To: X-Enigmail-Version: 1.4.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 619 Lines: 17 On 2012-11-09 01:17, Ed Cashin wrote: > Calling the request handler directly on a plugged queue defeats > the performance improvements provided by the plugging mechanism. > Use the __blk_run_queue function instead of calling the request > handler directly, so that we don't interfere with the block > layer's ability to plug the queue. Thanks Ed, applied! -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/