Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753246Ab2KIMUi (ORCPT ); Fri, 9 Nov 2012 07:20:38 -0500 Received: from gir.skynet.ie ([193.1.99.77]:57681 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472Ab2KIMUh (ORCPT ); Fri, 9 Nov 2012 07:20:37 -0500 Date: Fri, 9 Nov 2012 12:20:33 +0000 From: Mel Gorman To: Rafael Aquini Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , "Michael S. Tsirkin" , Rik van Riel , Andi Kleen , Andrew Morton , Konrad Rzeszutek Wilk , Minchan Kim , Peter Zijlstra , "Paul E. McKenney" Subject: Re: [PATCH v11 7/7] mm: add vm event counters for balloon pages compaction Message-ID: <20121109122033.GR3886@csn.ul.ie> References: <8dde7996f3e36a5efbe569afe1aadfc84355e79e.1352256088.git.aquini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <8dde7996f3e36a5efbe569afe1aadfc84355e79e.1352256088.git.aquini@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 29 On Wed, Nov 07, 2012 at 01:05:54AM -0200, Rafael Aquini wrote: > This patch introduces a new set of vm event counters to keep track of > ballooned pages compaction activity. > > Signed-off-by: Rafael Aquini Other than confirming the thing actually works can any meaningful conclusions be drawn from this counters? I know I have been inconsistent on this myself in the past but recently I've been taking the attitude that the counters can be used to fit into some other metric. I'm looking to change the compaction counters to be able to build a basic cost model for example. The same idea could be used for balloons of course but it's a less critical path than compaction for THP for example. Assuming it builds and all the defines are correct when the feature is not configured (I didn't check) then there is nothing wrong with the patch. However, if it was dropped would it make life very hard or would you notice? -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/