Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901Ab2KKJmA (ORCPT ); Sun, 11 Nov 2012 04:42:00 -0500 Received: from mail-vb0-f46.google.com ([209.85.212.46]:36000 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785Ab2KKJl6 convert rfc822-to-8bit (ORCPT ); Sun, 11 Nov 2012 04:41:58 -0500 MIME-Version: 1.0 In-Reply-To: <1350333885-20323-1-git-send-email-geert@linux-m68k.org> References: <1350333885-20323-1-git-send-email-geert@linux-m68k.org> Date: Sun, 11 Nov 2012 10:41:57 +0100 X-Google-Sender-Auth: HJoSk0yfkRKcjc9jXjt-xOR2yFw Message-ID: Subject: Re: [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks From: Geert Uytterhoeven To: David Dajun Chen , Ashish Jangam , Samuel Ortiz , Andrew Morton Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3340 Lines: 85 Ping? (akpm added to CC) On Mon, Oct 15, 2012 at 10:44 PM, Geert Uytterhoeven wrote: > Older gcc (< 4.4) doesn't like files starting with Unicode BOMs: > > include/linux/mfd/da9055/core.h:1: error: stray ‘\357’ in program > include/linux/mfd/da9055/core.h:1: error: stray ‘\273’ in program > include/linux/mfd/da9055/core.h:1: error: stray ‘\277’ in program > include/linux/mfd/da9055/pdata.h:1: error: stray ‘\357’ in program > include/linux/mfd/da9055/pdata.h:1: error: stray ‘\273’ in program > include/linux/mfd/da9055/pdata.h:1: error: stray ‘\277’ in program > include/linux/mfd/da9055/reg.h:1: error: stray ‘\357’ in program > include/linux/mfd/da9055/reg.h:1: error: stray ‘\273’ in program > include/linux/mfd/da9055/reg.h:1: error: stray ‘\277’ in program > > Remove the BOMs, the rest of the files is plain ASCII anyway. > > Output of "file" before: > > include/linux/mfd/da9055/core.h: UTF-8 Unicode (with BOM) C program text > include/linux/mfd/da9055/pdata.h: UTF-8 Unicode (with BOM) C program text > include/linux/mfd/da9055/reg.h: UTF-8 Unicode (with BOM) C program text > > Output of "file" after: > > include/linux/mfd/da9055/core.h: ASCII C program text > include/linux/mfd/da9055/pdata.h: ASCII C program text > include/linux/mfd/da9055/reg.h: ASCII C program text > > Signed-off-by: Geert Uytterhoeven > --- > include/linux/mfd/da9055/core.h | 2 +- > include/linux/mfd/da9055/pdata.h | 2 +- > include/linux/mfd/da9055/reg.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/mfd/da9055/core.h b/include/linux/mfd/da9055/core.h > index c96ad68..956afa4 100644 > --- a/include/linux/mfd/da9055/core.h > +++ b/include/linux/mfd/da9055/core.h > @@ -1,4 +1,4 @@ > -/* > +/* > * da9055 declarations for DA9055 PMICs. > * > * Copyright(c) 2012 Dialog Semiconductor Ltd. > diff --git a/include/linux/mfd/da9055/pdata.h b/include/linux/mfd/da9055/pdata.h > index 147293b..b9b204e 100644 > --- a/include/linux/mfd/da9055/pdata.h > +++ b/include/linux/mfd/da9055/pdata.h > @@ -1,4 +1,4 @@ > -/* Copyright (C) 2012 Dialog Semiconductor Ltd. > +/* Copyright (C) 2012 Dialog Semiconductor Ltd. > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > diff --git a/include/linux/mfd/da9055/reg.h b/include/linux/mfd/da9055/reg.h > index df237ee..2b592e0 100644 > --- a/include/linux/mfd/da9055/reg.h > +++ b/include/linux/mfd/da9055/reg.h > @@ -1,4 +1,4 @@ > -/* > +/* > * DA9055 declarations for DA9055 PMICs. > * > * Copyright(c) 2012 Dialog Semiconductor Ltd. > -- > 1.7.0.4 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/