Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753080Ab2KKR1K (ORCPT ); Sun, 11 Nov 2012 12:27:10 -0500 Received: from mail-ia0-f174.google.com ([209.85.210.174]:64599 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752835Ab2KKR1J (ORCPT ); Sun, 11 Nov 2012 12:27:09 -0500 MIME-Version: 1.0 In-Reply-To: <509FB25F.3030307@gmail.com> References: <64c5278ebdec503f83e9b7002bf13affb7f3260f.1351225085.git.viresh.kumar@linaro.org> <50991C41.50705@gmail.com> <509FB25F.3030307@gmail.com> Date: Sun, 11 Nov 2012 22:57:08 +0530 Message-ID: Subject: Re: [PATCH Resend V2] dt: add helper function to read u8 & u16 variables & arrays From: Viresh Kumar To: Rob Herring Cc: rob.herring@calxeda.com, grant.likely@secretlab.ca, linaro-dev@lists.linaro.org, andriy.shevchenko@intel.com, patches@linaro.org, devicetree-discuss@lists.ozlabs.org, spear-devel@list.st.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 25 On 11 November 2012 19:42, Rob Herring wrote: > On 11/06/2012 10:22 PM, viresh kumar wrote: >> cluster0: cluster@0 { >> + data1 = <0x50 0x60 0x70>; >> + data2 = <0x5000 0x6000 0x7000>; >> + data3 = <0x50000000 0x60000000 0x70000000>; > > So there is a mismatch in our assumptions. You are just truncating > 32-bit values. I assumed you were using the 8 and 16 bit sizes that are > now supported in dts. I don't think we should just truncate values > blindly. We have support for specifying 8 and 16 values now so you > should use that and define that as part of a binding. Sorry couldn't get your point at all :( What did you mean by "truncating 32 bit values" and how should we tell via DT, that the value passed is 8 bit, 16 bit or 32 bit? -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/