Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752689Ab2KLLxw (ORCPT ); Mon, 12 Nov 2012 06:53:52 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:61230 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417Ab2KLLxt (ORCPT ); Mon, 12 Nov 2012 06:53:49 -0500 MIME-Version: 1.0 In-Reply-To: <20121105214753.GB1254@beefymiracle.amer.corp.natinst.com> References: <20121105214753.GB1254@beefymiracle.amer.corp.natinst.com> Date: Mon, 12 Nov 2012 12:53:47 +0100 X-Google-Sender-Auth: pjktv39mIg6EnqB0Rg8QTieUOaQ Message-ID: Subject: Re: [PATCH 2/8] ARM: zynq: move ttc timer code to drivers/clocksource From: Michal Simek To: Josh Cartwright Cc: Russell King , John Stultz , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , linux-serial@vger.kernel.org, Greg Kroah-Hartman , Thomas Gleixner , Alan Cox , linux-arm-kernel@lists.infradead.org, Mike Turquette Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1937 Lines: 40 2012/11/5 Josh Cartwright : > On Mon, Nov 05, 2012 at 12:22:55PM +0100, Michal Simek wrote: >> 2012/10/29 Josh Cartwright : >> > Suggested cleanup by Arnd Bergmann. Move the ttc timer.c code to >> > drivers/clocksource, and out of the mach-zynq directory. >> > >> > The common.h (which only held the timer declaration) was renamed to >> > xilinx_ttc.h and moved into include/linux. >> > >> > Signed-off-by: Josh Cartwright >> > Cc: Arnd Bergmann >> > --- >> > arch/arm/mach-zynq/Makefile | 2 +- >> > arch/arm/mach-zynq/common.c | 2 +- >> > drivers/clocksource/Makefile | 1 + >> > arch/arm/mach-zynq/timer.c => drivers/clocksource/xilinx_ttc.c | 1 - >> > arch/arm/mach-zynq/common.h => include/linux/xilinx_ttc.h | 4 ++-- >> > 5 files changed, 5 insertions(+), 5 deletions(-) >> > rename arch/arm/mach-zynq/timer.c => drivers/clocksource/xilinx_ttc.c (99%) >> > rename arch/arm/mach-zynq/common.h => include/linux/xilinx_ttc.h (91%) >> >> Not going to apply this patch till there is clean way how to move all >> drivers there. Especially I don't like to add xilinx_ttc.h to >> include/linux folder. > > Okay; I think it's best to defer the moving of the ttc driver from this > patchset. It is not a dependency of the clk driver support stuff. > If you agree, I can spin up a v2 of the patchset w/o this change, and > without the serial CONFIG_OF stuff. Should v2 contain the patches > you've already pulled into testing? Sure and I see you have done which is good. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/