Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428Ab2KLPD3 (ORCPT ); Mon, 12 Nov 2012 10:03:29 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:48511 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039Ab2KLPD2 (ORCPT ); Mon, 12 Nov 2012 10:03:28 -0500 Message-ID: <50A10FA4.9070703@oracle.com> Date: Mon, 12 Nov 2012 10:03:00 -0500 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121024 Thunderbird/16.0.1 MIME-Version: 1.0 To: Jiri Kosina CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] alpha: use BUG_ON where possible References: <1352406191-14303-1-git-send-email-sasha.levin@oracle.com> <1352406191-14303-2-git-send-email-sasha.levin@oracle.com> <509D2DF8.4030602@oracle.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1127 Lines: 41 On 11/12/2012 09:43 AM, Jiri Kosina wrote: > On Fri, 9 Nov 2012, Sasha Levin wrote: > >>>> Just use BUG_ON() instead of constructions such as: >>>> >>>> if (...) >>>> BUG() >>>> >>>> A simplified version of the semantic patch that makes this transformation >>>> is as follows: (http://coccinelle.lip6.fr/) >>>> >>>> // >>>> @@ >>>> expression e; >>>> @@ >>>> - if (e) BUG(); >>>> + BUG_ON(e); >>> >>> Ok, I guess I am just going to apply this one. Thanks, >>> >> >> So I have about 80 more of these. I've sent out the first 10 to make sure >> that they look fine and the only complaints I got about them are that they are >> trivial :) >> >> Can I send the rest directly to you to go through the trivial tree? > > How many conflict can you see if you generate this patch on top of Linus' > tree and thn apply it to linux-next? > One context conflict. Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/