Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979Ab2KLQCG (ORCPT ); Mon, 12 Nov 2012 11:02:06 -0500 Received: from merlin.infradead.org ([205.233.59.134]:56205 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751402Ab2KLQCE (ORCPT ); Mon, 12 Nov 2012 11:02:04 -0500 Date: Mon, 12 Nov 2012 13:01:39 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Namhyung Kim , Ingo Molnar , linux-kernel@vger.kernel.org, Andi Kleen , Corey Ashford , David Ahern , Frederic Weisbecker , Irina Tirdea , Mike Galbraith , Paul Mackerras , Peter Zijlstra , stable@vger.kernel.org, Stephane Eranian , Steven Rostedt , Vinson Lee , Zheng Liu Subject: Re: [GIT PULL 00/21] perf/core improvements and fixes Message-ID: <20121112160139.GC18978@ghostprotocols.net> References: <1352497390-17716-1-git-send-email-acme@infradead.org> <87390fo9jn.fsf@sejong.aot.lge.com> <20121112135545.GA4595@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121112135545.GA4595@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2127 Lines: 50 Em Mon, Nov 12, 2012 at 02:55:46PM +0100, Jiri Olsa escreveu: > On Mon, Nov 12, 2012 at 11:10:52AM +0900, Namhyung Kim wrote: > > On Fri, 9 Nov 2012 18:42:49 -0300, Arnaldo Carvalho de Melo wrote: > > > . Add a 'link' method for hists, so that we can have the leader with > > > buckets for all the entries in all the hists. This new method > > > is now used in the default 'diff' output, making the sum of the 'baseline' > > > column be 100%, eliminating blind spots. Now we need to use this > > > for 'diff' with > 2 perf.data files and for multi event 'report' and > > > 'annotate'. > > I'm not sure it can be used for group report at least in its current > > form. IIUC it connects multiple hist entries using a list head and > > create a dummy entry in the leader if need be. But it didn't handle > > non-leader entries so it's hard to tell which is which if less entries > > are present only. For example consider following case: > > leader member1 member2 > > A A A > > B > > C > > D > > where leader, member1 and member2 are evsel/hists and A, B, C and D are > > hist entries. After 'linking' the entries the leader will have > > following linkage: > > leader > > A -> A -> A > > B > > C (dummy) -> C > > D (dummy) -> D > > In this case, for entry A the leader can determine which entry came from > > which hists by looking its order in the list. For entry B the leader > > can use zero value for them since the list is empty. However for > > entries C and D, it cannot know which one is the right hists unless it > > records a hist index or creates dummy entry and insert it in a correct > > order (looks far from an optimal solution). Am I missing something? > there's hists pointer in hist_entry if that's what you look for And from there to evsel->idx. In your patchset you even introduce hists_2_evsel(), right? - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/