Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752438Ab2KLQ5M (ORCPT ); Mon, 12 Nov 2012 11:57:12 -0500 Received: from c62.cesmail.net ([216.154.195.54]:9530 "EHLO c62.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832Ab2KLQ5K (ORCPT ); Mon, 12 Nov 2012 11:57:10 -0500 Message-ID: <20121112115707.r8h545480kg0cgkk-cebfxv@webmail.spamcop.net> Date: Mon, 12 Nov 2012 11:57:07 -0500 From: Pavel Roskin To: Eric Paris Cc: Al Viro , Linux Kernel Mailing List , SE-Linux Subject: Re: Bisected regression: iterate_fd() selinux change affects flash plugin References: <20121025101416.v1wilj95q8wkk0os-cebfxv@webmail.spamcop.net> <20121111235001.a3gqhaijmec0gk0g-cebfxv@webmail.spamcop.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 23 Quoting Eric Paris : > OMG this +1 -1 stuff is nuts... > > iterate_fd passes fd+1 instead of the fd for the file? seriously? > ewwww. I see how this patch fixes it, but still, wouldn't some magic > or negative value for no entries found be better than having to > understand the crazy logics? I agree. -ENOENT is both magic and negative :) I tend to think now that iterate_fd() should be rewritten before it's too late and all its current users should be cross-checked against the code prior to the introduction of iterate_fd(). -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/