Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753862Ab2KLRTQ (ORCPT ); Mon, 12 Nov 2012 12:19:16 -0500 Received: from li42-95.members.linode.com ([209.123.162.95]:34279 "EHLO li42-95.members.linode.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339Ab2KLRTP convert rfc822-to-8bit (ORCPT ); Mon, 12 Nov 2012 12:19:15 -0500 Subject: Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2) Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Pantelis Antoniou In-Reply-To: <50A12D9D.5030300@wwwdotorg.org> Date: Mon, 12 Nov 2012 19:19:08 +0200 Cc: Grant Likely , Rob Herring , Deepak Saxena , Benjamin Herrenschmidt , Scott Wood , Tony Lindgren , Kevin Hilman , Matt Porter , Koen Kooi , linux-kernel , Felipe Balbi , Russ Dill , linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Content-Transfer-Encoding: 8BIT Message-Id: References: <50999145.2070306@wwwdotorg.org> <50A128AF.1010803@wwwdotorg.org> <7C181180-2FE7-4EE4-BB5A-D7A1ACEC4244@antoniou-consulting.com> <50A12D9D.5030300@wwwdotorg.org> To: Stephen Warren X-Mailer: Apple Mail (2.1085) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4292 Lines: 101 Hi Stephen, On Nov 12, 2012, at 7:10 PM, Stephen Warren wrote: > On 11/12/2012 10:00 AM, Pantelis Antoniou wrote: >> Hi Stephen, >> >> On Nov 12, 2012, at 6:49 PM, Stephen Warren wrote: >> >>> On 11/12/2012 04:23 AM, Pantelis Antoniou wrote: >>>> Hi Grant, >>>> >>>> Sorry for the late comments, travelling... >>>> >>>> On Nov 9, 2012, at 6:28 PM, Grant Likely wrote: >>> ... >>>>> *with the caveat that not all types of changes are a good idea and we >>>>> may disallow. For example, is changing properties in existing nodes a >>>>> good idea? >>>> >>>> Yes, changing properties is something that we need. One such change is >>>> the change of the bus controller 'status' properties to enabled upon >>>> insertion of a child device node, and change back to 'on-demand' when >>>> all the child device nodes are gone. >>> >>> Do we actually need to do that? >>> >>> From the base-board perspective, consider an SoC's I2C channel that is >>> routed to the child board connector. The routing to the connector is >>> always present on the base board. Only the presence (or lack thereof) of >>> devices on that I2C bus is influenced by whether a child board is >>> connected or not, and the design of the child board. Therefore, wouldn't >>> it make sense for the base board to always enable the I2C controller? >>> >>> That would make it easier for someone to hook up a couple wires to the >>> I2C pins and use utilities such as i2cget/set to communicate with it, >>> without going through the whole process of creating a DT to represent >>> the device. This could speed up simple hacking/prototyping and allow it >>> to proceed in a less structured way. >> >> Unfortunately that doesn't work for the beaglebone (am355x) and a large >> number of general purpose SoCs. >> >> What is different between general purpose SoCs and vertical market SoCs >> (i.e. OMAP) is that the design of the the latter is for devices where >> pretty much all the interfaces are expected to be active at the same time. >> >> General purpose SoCs put more peripherals in the SoC, but due to packaging >> considerations (and price), the peripheral pins are highly muxed. >> >> So the i2c bus pins are shared with the LCD controller are shared with the >> analog input and so on. >> >> It is impossible (and on top of that really dangerous) to enable peripheral >> blocks without knowing what's connected on the other side. >> >> In a nutshell, for the bone and similar devices, probing with the devices >> enabled doesn't work. > > I think this can be solved by deferring the pinmux to the .dts for the > child board. Presumably the I2C controller node can be enabled just > fine, but the I2C signals not actually routed out to any pins on the SoC > until the specific pinmux configuration is loaded. > Well, I2C is just an example; same thing happens with SPI, LCD, audio, etc. So you'll end up hacking the device drivers to handle a weird state that basically means 'don't activate until I tell you to go'. It is simpler just not to create the device. > But your explanation still feels a little odd; is it really true on the > BeagleBone, you can either use LCD for graphics /or/ you can use the I2C > controller to communicate with a cape? I certainly fully understand that > from a SoC's perspective (and soc.dtsi perspective) you can't just > enable everything due to pinmux constraints, but it seems that once you > get to the level of a particular board design, the designer has made > those trade-offs and so you know which specific combination is to be > selected. There are multiple I2C busses, multiple SPI buses, multiple options to connect something that produces audio, and so on. It is not odd at the least for the kind of market these chips are for. Even TI doesn't know exactly the kind of applications these devices will be used for. The chip is there to provide connection option at a (cheap) price point. Think of a swiss-army knife with some tools that can be used at the same time, and some that can't. Regards -- Pantelis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/