Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753385Ab2KLWKx (ORCPT ); Mon, 12 Nov 2012 17:10:53 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:40879 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212Ab2KLWKv (ORCPT ); Mon, 12 Nov 2012 17:10:51 -0500 MIME-Version: 1.0 In-Reply-To: References: <20121024232032.GA31129@www.outflux.net> <20121025041620.GH2616@ZenIV.linux.org.uk> <20121025120952.GI2616@ZenIV.linux.org.uk> <20121025123843.GJ2616@ZenIV.linux.org.uk> <20121026183601.GR2616@ZenIV.linux.org.uk> Date: Mon, 12 Nov 2012 14:10:50 -0800 X-Google-Sender-Auth: pgf4b3P4XSUS45EI47abPBnkVWE Message-ID: Subject: Re: [PATCH] exec: do not leave bprm->interp on stack From: Kees Cook To: P J P Cc: Al Viro , linux-kernel@vger.kernel.org, Andrew Morton , Josh Triplett , Serge Hallyn , linux-fsdevel@vger.kernel.org, halfdog Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 29 On Tue, Nov 6, 2012 at 12:10 AM, P J P wrote: > > Hello Kees, Al, > > +-- On Sat, 27 Oct 2012, Kees Cook wrote --+ > | If we change binfmt_script to not make a recursive call, then we still > | need to keep the interp change somewhere off the stack. I still think > | my patchset is the least bad. > | > | Al, do you have something else in mind? > > Guys, are there any updates further? > > Al, what's your take on the *rare* extra call to request_module? Without any other feedback, I'd like to use my minimal allocation patch, since it fixes the problem and doesn't change any of the semantics of how/when loading happens. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/