Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754234Ab2KLXbR (ORCPT ); Mon, 12 Nov 2012 18:31:17 -0500 Received: from a193-30.smtp-out.amazonses.com ([199.255.193.30]:31620 "EHLO a193-30.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523Ab2KLXbP (ORCPT ); Mon, 12 Nov 2012 18:31:15 -0500 Date: Mon, 12 Nov 2012 23:31:13 +0000 From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Shan Wei cc: venkat.x.venkatsubra@oracle.com, David Miller , rds-devel@oss.oracle.com, NetDev , Kernel-Maillist Subject: Re: [PATCH v3 2/9] net: rds: use this_cpu_ptr per-cpu helper In-Reply-To: <50A0EFE7.9010100@gmail.com> Message-ID: <0000013af6f6652c-8e110b17-56dc-4119-899a-02a627c5485a-000000@email.amazonses.com> References: <509C687E.1080106@gmail.com> <0000013ae6cadebe-0e44d6a0-5e8c-4ded-a337-d2f41f2ab0e4-000000@email.amazonses.com> <50A0EFE7.9010100@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SES-Outgoing: 199.255.193.30 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 25 On Mon, 12 Nov 2012, Shan Wei wrote: > __percpu annotations in struct rds_ib_refill_cache is missing. > > you mean that read/write fields of struct rds_ib_cache_head > using __this_cpu_* operation like following? > How about it? > > diff --git a/net/rds/ib.h b/net/rds/ib.h > index 8d2b3d5..7280ab8 100644 > --- a/net/rds/ib.h > +++ b/net/rds/ib.h > @@ -50,7 +50,7 @@ struct rds_ib_cache_head { > }; > > struct rds_ib_refill_cache { > - struct rds_ib_cache_head *percpu; > + struct rds_ib_cache_head __percpu *percpu; That looks ok. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/