Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908Ab2KMCcM (ORCPT ); Mon, 12 Nov 2012 21:32:12 -0500 Received: from relay1.sgi.com ([192.48.179.29]:58013 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247Ab2KMCcL (ORCPT ); Mon, 12 Nov 2012 21:32:11 -0500 Date: Mon, 12 Nov 2012 20:32:07 -0600 From: Ben Myers To: Thiago Farina Cc: Dave Chinner , Alex Elder , linux list , xfs@oss.sgi.com Subject: Re: xfs: Remove boolean_t typedef completely. Message-ID: <20121113023207.GZ9783@sgi.com> References: <20121113015318.GD25039@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1726 Lines: 47 Hi Thiago, On Tue, Nov 13, 2012 at 12:02:14AM -0200, Thiago Farina wrote: > On Mon, Nov 12, 2012 at 11:53 PM, Dave Chinner wrote: > > On Mon, Nov 12, 2012 at 10:36:47PM -0200, Thiago Farina wrote: > >> On Mon, Nov 12, 2012 at 10:24 PM, Dave Chinner wrote: > >> > On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote: > >> >> Hi, > >> >> > >> >> Please, take a look. > >> >> > >> >> Patch attached. > >> > > >> > It's a good start for a cleanup, but there's no point in removing > >> > the boolean_t from one file and then not removing it from the rest > >> > of the XFS code. It's only used in a handful of places, so just > >> > remove it completely. > >> > > >> Done. > >> > >> Please, take another look. > >> > >> > Also, can you please place patches in line rather than attaching > >> > them. Attaching them means they cannot be quoted in reply. See > >> > Documentation/SubmittingPatches and Documentation/email-clients.txt > >> > for guidelines. > >> > > >> Sorry, patch attached. > > > > It's still attached as a base64 encoded attachment, not as inline > > text.... > > > Yep, sorry about that. Is just a text file from $(git format-patch master); If you don't mind another try... it would be helpful if you could resend the patch inline. It helps to facilitate a discussion of the patch along with your text should it be necessary. You're only touching xfs, so you can drop linux-kernel if you want. Thanks, Ben -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/