Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754085Ab2KMHpc (ORCPT ); Tue, 13 Nov 2012 02:45:32 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40361 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753594Ab2KMHp1 (ORCPT ); Tue, 13 Nov 2012 02:45:27 -0500 Date: Tue, 13 Nov 2012 08:45:23 +0100 (CET) From: Jiri Kosina To: Benjamin Tissoires Cc: Dmitry Torokhov , Henrik Rydberg , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 01/13] HID: hid-input: export hidinput_calc_abs_res In-Reply-To: <1352306256-12180-2-git-send-email-benjamin.tissoires@gmail.com> Message-ID: References: <1352306256-12180-1-git-send-email-benjamin.tissoires@gmail.com> <1352306256-12180-2-git-send-email-benjamin.tissoires@gmail.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3569 Lines: 86 On Wed, 7 Nov 2012, Benjamin Tissoires wrote: > Exporting the function allows us to calculate the resolution in third > party drivers like hid-multitouch. > This patch also complete the function with additional valid axes. > > Signed-off-by: Benjamin Tissoires Acked-by: Jiri Kosina > --- > drivers/hid/hid-input.c | 9 ++++++++- > drivers/hid/hid-multitouch.c | 1 + > include/linux/hid.h | 1 + > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c > index 10248cf..f5b1d57 100644 > --- a/drivers/hid/hid-input.c > +++ b/drivers/hid/hid-input.c > @@ -208,7 +208,7 @@ static int hidinput_setkeycode(struct input_dev *dev, > * Only exponent 1 length units are processed. Centimeters and inches are > * converted to millimeters. Degrees are converted to radians. > */ > -static __s32 hidinput_calc_abs_res(const struct hid_field *field, __u16 code) > +__s32 hidinput_calc_abs_res(const struct hid_field *field, __u16 code) > { > __s32 unit_exponent = field->unit_exponent; > __s32 logical_extents = field->logical_maximum - > @@ -229,6 +229,12 @@ static __s32 hidinput_calc_abs_res(const struct hid_field *field, __u16 code) > case ABS_X: > case ABS_Y: > case ABS_Z: > + case ABS_MT_POSITION_X: > + case ABS_MT_POSITION_Y: > + case ABS_MT_TOOL_X: > + case ABS_MT_TOOL_Y: > + case ABS_MT_TOUCH_MAJOR: > + case ABS_MT_TOUCH_MINOR: > if (field->unit == 0x11) { /* If centimeters */ > /* Convert to millimeters */ > unit_exponent += 1; > @@ -283,6 +289,7 @@ static __s32 hidinput_calc_abs_res(const struct hid_field *field, __u16 code) > /* Calculate resolution */ > return logical_extents / physical_extents; > } > +EXPORT_SYMBOL_GPL(hidinput_calc_abs_res); > > #ifdef CONFIG_HID_BATTERY_STRENGTH > static enum power_supply_property hidinput_battery_props[] = { > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 3eb02b9..9f64e36 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -298,6 +298,7 @@ static void set_abs(struct input_dev *input, unsigned int code, > int fmax = field->logical_maximum; > int fuzz = snratio ? (fmax - fmin) / snratio : 0; > input_set_abs_params(input, code, fmin, fmax, fuzz, 0); > + input_abs_set_res(input, code, hidinput_calc_abs_res(field, code)); > } > > static void mt_store_field(struct hid_usage *usage, struct mt_device *td, > diff --git a/include/linux/hid.h b/include/linux/hid.h > index 7e1f37d..9edb06c 100644 > --- a/include/linux/hid.h > +++ b/include/linux/hid.h > @@ -743,6 +743,7 @@ int hid_input_report(struct hid_device *, int type, u8 *, int, int); > int hidinput_find_field(struct hid_device *hid, unsigned int type, unsigned int code, struct hid_field **field); > struct hid_field *hidinput_get_led_field(struct hid_device *hid); > unsigned int hidinput_count_leds(struct hid_device *hid); > +__s32 hidinput_calc_abs_res(const struct hid_field *field, __u16 code); > void hid_output_report(struct hid_report *report, __u8 *data); > struct hid_device *hid_allocate_device(void); > struct hid_report *hid_register_report(struct hid_device *device, unsigned type, unsigned id); > -- > 1.7.11.7 > -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/