Date: Tue, 13 Nov 2012 14:49:10 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Andrea Arcangeli <aarcange@redhat.com>, Rik van Riel <riel@redhat.com>,
        Johannes Weiner <hannes@cmpxchg.org>, Hugh Dickins <hughd@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 08/19] mm: numa: Create basic numa page hinting
 infrastructure
Message-ID: <20121113134910.GB17782@gmail.com>
References: <1352193295-26815-1-git-send-email-mgorman@suse.de>
 <1352193295-26815-9-git-send-email-mgorman@suse.de>
 <20121113102120.GD21522@gmail.com>
 <20121113115032.GY8218@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121113115032.GY8218@suse.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1231
Lines: 35


* Mel Gorman <mgorman@suse.de> wrote:

> > But given that most architectures will be just fine reusing 
> > the already existing generic PROT_NONE machinery, the far 
> > better approach is to do what we've been doing in generic 
> > kernel code for the last 10 years: offer a default generic 
> > version, and then to offer per arch hooks on a strict 
> > as-needed basis, if they want or need to do something weird 
> > ...
> 
> If they are *not* fine with it, it's a large retrofit because 
> the PROT_NONE machinery has been hard-coded throughout. [...]

That was a valid criticism for earlier versions of the NUMA 
patches - but should much less be the case in the latest 
iterations of the patches:

 - it has generic pte_numa() / pmd_numa() instead of using
   prot_none() directly

 - the key utility functions are named using the _numa pattern,
   not *_prot_none*() anymore.

Let us know if you can still see such instances - it's probably 
simple oversight.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/