Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755519Ab2KMSea (ORCPT ); Tue, 13 Nov 2012 13:34:30 -0500 Received: from mail-ea0-f174.google.com ([209.85.215.174]:60632 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005Ab2KMSe3 convert rfc822-to-8bit (ORCPT ); Tue, 13 Nov 2012 13:34:29 -0500 MIME-Version: 1.0 In-Reply-To: <50A1F0D6.7040403@gmail.com> References: <20121112193044.GA11615@phenom.dumpdata.com> <1352755122-25660-1-git-send-email-yinghai@kernel.org> <1352755122-25660-3-git-send-email-yinghai@kernel.org> <50A1DFE1.3070809@jp.fujitsu.com> <50A1F0D6.7040403@gmail.com> Date: Tue, 13 Nov 2012 10:34:27 -0800 X-Google-Sender-Auth: kAUXNgALbjw-2EdZ5rIc8S5WmuM Message-ID: Subject: Re: [PATCH 02/46] x86, mm: Split out split_mem_range from init_memory_mapping From: Yinghai Lu To: snakky.zhang@gmail.com Cc: Yasuaki Ishimatsu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jacob Shin , Andrew Morton , Stefano Stabellini , Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 836 Lines: 24 On Mon, Nov 12, 2012 at 11:03 PM, wrote: > On 2012年11月13日 14:20, Yinghai Lu wrote: >>> 2012/11/13 6:17, Yinghai Lu wrote: >>>> >>>> + nr_range = 0; >>> >>> This is unnecessary since it is set in the below. >>> >>>> + nr_range = split_mem_range(mr, nr_range, start, end); >> >> ^^^^^^^^ > > Why not use 0 directly? > > nr_range = split_mem_range(mr, 0, start, end); yes, even could remove nr_range from split_mem_range. but originally try to like "really" chopping the code to two parts. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/