Date: Tue, 13 Nov 2012 14:38:08 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        Al Viro <viro@zeniv.linux.org.uk>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Pavel Emelyanov <xemul@parallels.com>,
        James Bottomley <jbottomley@parallels.com>,
        Matthew Helsley <matt.helsley@gmail.com>,
        aneesh.kumar@linux.vnet.ibm.com, bfields@fieldses.org
Subject: Re: [patch 3/7] fs, notify: Add file handle entry into
 inotify_inode_mark
Message-Id: <20121113143808.8d198bfe.akpm@linux-foundation.org>
In-Reply-To: <20121113080032.GF6511@moon>
References: <20121112101440.665694060@openvz.org>
	<20121112101845.839702715@openvz.org>
	<20121112165540.2ec39f50.akpm@linux-foundation.org>
	<20121113072057.GC6511@moon>
	<20121112234001.009b2ae3.akpm@linux-foundation.org>
	<20121113080032.GF6511@moon>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 807
Lines: 18

On Tue, 13 Nov 2012 12:00:32 +0400
Cyrill Gorcunov <gorcunov@openvz.org> wrote:

> > Dumb question: do we really need inotify_inode_mark.fhandle at all? 
> > What prevents us from assembling this info on demand when ->show_fdinfo() is
> > called?
> 
> exportfs requires the dentry to be passed as an argument while inotify works
> with inodes instead and at moment of show-fdinfo the target dentry might be
> already deleted but inode yet present as far as I remember.

How can the c/r restore code reestablish the inode data if the dentry
isn't there any more?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/