Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932466Ab2KNCbt (ORCPT ); Tue, 13 Nov 2012 21:31:49 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:26694 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932406Ab2KNCbs (ORCPT ); Tue, 13 Nov 2012 21:31:48 -0500 X-Authority-Analysis: v=2.0 cv=NLdXCjGg c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=LmWu7n8Vm5kA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=meVymXHHAAAA:8 a=c4Q_C9-CEacA:10 a=m4aFBlJfEDBMt36WKB8A:9 a=PUjeQqilurYA:10 a=jeBq3FmKZ4MA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.115.198 Message-ID: <1352860305.18025.48.camel@gandalf.local.home> Subject: Re: [RFC PATCH 0/2] kvm/vmx: Output TSC offset From: Steven Rostedt To: David Sharp Cc: Yoshihiro YUNOMAE , linux-kernel@vger.kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org, Joerg Roedel , Marcelo Tosatti , Hidehiro Kawai , Ingo Molnar , Avi Kivity , yrl.pp-manager.tt@hitachi.com, Masami Hiramatsu , Thomas Gleixner Date: Tue, 13 Nov 2012 21:31:45 -0500 In-Reply-To: References: <20121114013611.5338.15086.stgit@yunodevel> <1352858437.18025.47.camel@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.4.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 33 On Tue, 2012-11-13 at 18:03 -0800, David Sharp wrote: > On Tue, Nov 13, 2012 at 6:00 PM, Steven Rostedt wrote: > > On Wed, 2012-11-14 at 10:36 +0900, Yoshihiro YUNOMAE wrote: > > > >> To merge the data like previous pattern, we apply this patch set. Then, we can > >> get TSC offset of the guest as follows: > >> > >> $ dmesg | grep kvm > >> [ 57.717180] kvm: (2687) write TSC offset 18446743360465545001, now clock ## > >> ^^^^ ^^^^^^^^^^^^^^^^^^^^ | > >> PID TSC offset | > >> HOST TSC value --+ > >> > > > > Using printk to export something like this is IMO a nasty hack. > > > > Can't we create a /sys or /proc file to export the same thing? > > Since the value changes over the course of the trace, and seems to be > part of the context of the trace, I think I'd include it as a > tracepoint. > I'm fine with that too. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/