Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161197Ab2KNML2 (ORCPT ); Wed, 14 Nov 2012 07:11:28 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:47667 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161153Ab2KNML1 (ORCPT ); Wed, 14 Nov 2012 07:11:27 -0500 MIME-Version: 1.0 In-Reply-To: <50A1D452.2020904@wwwdotorg.org> References: <1352638249-29298-1-git-send-email-jonas.gorski@gmail.com> <1352638249-29298-10-git-send-email-jonas.gorski@gmail.com> <50A1D452.2020904@wwwdotorg.org> From: Jonas Gorski Date: Wed, 14 Nov 2012 13:11:06 +0100 Message-ID: Subject: Re: [RFC] MIPS: BCM63XX: add Device Tree clock definitions To: Stephen Warren Cc: linux-mips@linux-mips.org, Ralf Baechle , John Crispin , Maxime Bizon , Florian Fainelli , Kevin Cernekee , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 30 On 13 November 2012 06:02, Stephen Warren wrote: > On 11/11/2012 05:50 AM, Jonas Gorski wrote: >> Add definitions for the clocks found and used in all supported SoCs. > >> diff --git a/arch/mips/bcm63xx/dts/bcm6328.dtsi b/arch/mips/bcm63xx/dts/bcm6328.dtsi > >> + clocks { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + periph: pll { >> + compatible = "brcm,bcm63xx-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <50000000>; >> + clock-output-names = "periph"; >> + }; > > Here too, it seems like some reg properties would be required. This is more or less a dummy clock with no real backing for it, but some of the drivers expect this clock to be present (even just to get the frequency). Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/