Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161205Ab2KNMOH (ORCPT ); Wed, 14 Nov 2012 07:14:07 -0500 Received: from mail-oa0-f46.google.com ([209.85.219.46]:64808 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161153Ab2KNMOF (ORCPT ); Wed, 14 Nov 2012 07:14:05 -0500 MIME-Version: 1.0 In-Reply-To: <50A1D54E.2090406@wwwdotorg.org> References: <1352638249-29298-1-git-send-email-jonas.gorski@gmail.com> <1352638249-29298-12-git-send-email-jonas.gorski@gmail.com> <50A1D54E.2090406@wwwdotorg.org> From: Jonas Gorski Date: Wed, 14 Nov 2012 13:13:44 +0100 Message-ID: Subject: Re: [RFC] MIPS: BCM63XX: register GPIO controller through Device Tree To: Stephen Warren Cc: linux-mips@linux-mips.org, Ralf Baechle , John Crispin , Maxime Bizon , Florian Fainelli , Kevin Cernekee , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1449 Lines: 31 On 13 November 2012 06:06, Stephen Warren wrote: > On 11/11/2012 05:50 AM, Jonas Gorski wrote: >> Register the GPIO controller through Device Tree and add the >> appropriate values in the include files. >> >> Since we can't register a platform driver at this early stage move the >> direct call to bcm63xx_gpio_init from prom_init to an arch initcall. > >> diff --git a/Documentation/devicetree/bindings/gpio/bcm63xx-gpio.txt b/Documentation/devicetree/bindings/gpio/bcm63xx-gpio.txt > >> +- #gpio-cells: Must be <2>. The first cell is the GPIO pin, and >> + the second one the standard linux flags. > > Also here, I think you want to explicitly document the flag values here > so the bindings don't rely on the Linux kernel code. I don't think > there's a standard central file which documents them though, although I > vaguely recall some discussion to create add them to gpio.txt? I'll add some more description. And yes there isn't, and I can't comment about that since I just joined devicetree-discuss a few days ago. It would be nice to have them there. Maybe I'll add a reference to gpio.txt and see if I can come up with an acceptable description for the flags. Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/