Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423468Ab2KNVZr (ORCPT ); Wed, 14 Nov 2012 16:25:47 -0500 Received: from mail-1-out2.atlantis.sk ([80.94.52.71]:32938 "EHLO mail.atlantis.sk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754884Ab2KNVZq (ORCPT ); Wed, 14 Nov 2012 16:25:46 -0500 From: Ondrej Zary To: Dan Carpenter Subject: Re: [patch] ALSA: es1968: precedence bug in snd_es1968_tea575x_get_pins() Date: Wed, 14 Nov 2012 22:24:18 +0100 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: Jaroslav Kysela , Takashi Iwai , Mauro Carvalho Chehab , Hans de Goede , Rusty Russell , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20121113074454.GB13198@elgon.mountain> In-Reply-To: <20121113074454.GB13198@elgon.mountain> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201211142224.19938.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1734 Lines: 53 On Tuesday 13 November 2012 08:44:54 Dan Carpenter wrote: > I don't think this works as intended. '|' higher precedence than ?: so > the bitwize OR "0 | (val & STR_MOST)" is a no-op. > > I have re-written it to be more clear. > > Signed-off-by: Dan Carpenter > --- > I don't have a way to test this. Thanks for the patch. I tested it and it works. The same way as without the patch...weird. DATA pin reading works because that's required for the chip detection. Stereo indication (MOST pin) works too. > > diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c > index 50169bc..7266020 100644 > --- a/sound/pci/es1968.c > +++ b/sound/pci/es1968.c > @@ -2581,9 +2581,14 @@ static u8 snd_es1968_tea575x_get_pins(struct > snd_tea575x *tea) struct es1968 *chip = tea->private_data; > unsigned long io = chip->io_port + GPIO_DATA; > u16 val = inw(io); > - > - return (val & STR_DATA) ? TEA575X_DATA : 0 | > - (val & STR_MOST) ? TEA575X_MOST : 0; > + u8 ret; > + > + ret = 0; > + if (val & STR_DATA) > + ret |= TEA575X_DATA; > + if (val & STR_MOST) > + ret |= TEA575X_MOST; > + return ret; > } > > static void snd_es1968_tea575x_set_direction(struct snd_tea575x *tea, bool > output) -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/