Message-ID: <1352946459.18025.88.camel@gandalf.local.home>
Subject: Re: [PATCH 4/4] kernelshark: Full-height cursor and mark lines
From: Steven Rostedt <rostedt@goodmis.org>
To: David Sharp <dhsharp@google.com>
Cc: linux-kernel@vger.kernel.org
Date: Wed, 14 Nov 2012 21:27:39 -0500
In-Reply-To: <1352944274-21699-4-git-send-email-dhsharp@google.com>
References: <1352944274-21699-1-git-send-email-dhsharp@google.com>
	 <1352944274-21699-4-git-send-email-dhsharp@google.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2201
Lines: 62

On Wed, 2012-11-14 at 17:51 -0800, David Sharp wrote:
> "width" and "height" were swapped, causing the vertical marker and cursor lines
> to be drawn with the wrong height.

Is this the fix to the strange "mark bottom stays around" bug? It's been
on my TODO list for a long time to fix that. ;-)

-- Steve

> 
> Signed-off-by: David Sharp <dhsharp@google.com>
> ---
>  trace-graph.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/trace-graph.c b/trace-graph.c
> index 6f72350..60e5241 100644
> --- a/trace-graph.c
> +++ b/trace-graph.c
> @@ -380,7 +380,7 @@ static void draw_cursor(struct graph_info *ginfo)
>  	x = convert_time_to_x(ginfo, ginfo->cursor);
>  
>  	gdk_draw_line(ginfo->draw->window, ginfo->draw->style->mid_gc[3],
> -		      x, 0, x, ginfo->draw->allocation.width);
> +		      x, 0, x, ginfo->draw->allocation.height);
>  }
>  
>  static void draw_marka(struct graph_info *ginfo)
> @@ -392,7 +392,7 @@ static void draw_marka(struct graph_info *ginfo)
>  
>  	x = convert_time_to_x(ginfo, ginfo->marka_time);
>  	gdk_draw_line(ginfo->draw->window, green,
> -		      x, 0, x, ginfo->draw->allocation.width);
> +		      x, 0, x, ginfo->draw->allocation.height);
>  }
>  
>  static void draw_markb(struct graph_info *ginfo)
> @@ -404,7 +404,7 @@ static void draw_markb(struct graph_info *ginfo)
>  
>  	x = convert_time_to_x(ginfo, ginfo->markb_time);
>  	gdk_draw_line(ginfo->draw->window, red,
> -		      x, 0, x, ginfo->draw->allocation.width);
> +		      x, 0, x, ginfo->draw->allocation.height);
>  }
>  
>  static void update_with_backend(struct graph_info *ginfo,
> @@ -434,7 +434,7 @@ static void
>  draw_line(GtkWidget *widget, gdouble x, struct graph_info *ginfo)
>  {
>  	gdk_draw_line(widget->window, widget->style->black_gc,
> -		      x, 0, x, widget->allocation.width);
> +		      x, 0, x, widget->allocation.height);
>  }
>  
>  static void clear_line(struct graph_info *ginfo, gint x)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/