Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756706Ab2KOJEu (ORCPT ); Thu, 15 Nov 2012 04:04:50 -0500 Received: from mail-vc0-f174.google.com ([209.85.220.174]:35448 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753602Ab2KOJEm (ORCPT ); Thu, 15 Nov 2012 04:04:42 -0500 MIME-Version: 1.0 In-Reply-To: <1352944590-8776-1-git-send-email-jwerner@chromium.org> References: <1352944590-8776-1-git-send-email-jwerner@chromium.org> Date: Thu, 15 Nov 2012 14:34:41 +0530 Message-ID: Subject: Re: [PATCH] cpuidle: Measure idle state durations with monotonic clock From: Preeti Murthy To: Julius Werner Cc: linux-kernel@vger.kernel.org, Len Brown , "Rafael J. Wysocki" , Kevin Hilman , Andrew Morton , "Srivatsa S. Bhat" , linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Deepthi Dharwar , Trinabh Gupta , Sameer Nanda , Lists Linaro-dev , Daniel Lezcano , Peter Zijlstra Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 26 Hi all, The code looks correct and inviting to me as it has led to good cleanups. I dont think passing 0 as the argument to the function sched_clock_idle_wakeup_event() should lead to problems,as it does not do anything useful with the passed arguments. My only curiosity is what was the purpose of passing idle residency time to sched_clock_idle_wakeup_event() when this data could always be retrieved from dev->last_residency for each cpu,which gets almost immediately updated. But this does not seem to come in way of this patch for now.Anyway I have added Peter to the list so that he can opine about this issue if possible and needed. Reviewed-by: Preeti U Murthy Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/