Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946036Ab2KOJWz (ORCPT ); Thu, 15 Nov 2012 04:22:55 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:48060 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933008Ab2KOJWx (ORCPT ); Thu, 15 Nov 2012 04:22:53 -0500 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <50A4B44F.1040006@jp.fujitsu.com> Date: Thu, 15 Nov 2012 18:22:23 +0900 From: Yasuaki Ishimatsu User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Wen Congyang CC: , , , Len Brown , "Rafael J. Wysocki" , Andrew Morton , Lai Jiangshan , Jiang Liu , KOSAKI Motohiro , Minchan Kim , Mel Gorman , David Rientjes , Konrad Rzeszutek Wilk , Toshi Kani , Jiang Liu , Benjamin Herrenschmidt , Paul Mackerras , Christoph Lameter Subject: Re: [Patch v5 6/7] acpi_memhotplug.c: bind the memory device when the driver is being loaded References: <1352962777-24407-1-git-send-email-wency@cn.fujitsu.com> <1352962777-24407-7-git-send-email-wency@cn.fujitsu.com> In-Reply-To: <1352962777-24407-7-git-send-email-wency@cn.fujitsu.com> Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2572 Lines: 75 2012/11/15 15:59, Wen Congyang wrote: > We had introduced acpi_hotmem_initialized to avoid strange add_memory fail > message. But the memory device may not be used by the kernel, and the > device should be bound when the driver is being loaded. Remove > acpi_hotmem_initialized to allow that the device can be bound when the > driver is being loaded. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Yasuaki Ishimatsu > CC: Rafael J. Wysocki > CC: Konrad Rzeszutek Wilk > Signed-off-by: Wen Congyang > --- Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > drivers/acpi/acpi_memhotplug.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > index f7e3007..e0f7425 100644 > --- a/drivers/acpi/acpi_memhotplug.c > +++ b/drivers/acpi/acpi_memhotplug.c > @@ -87,8 +87,6 @@ struct acpi_memory_device { > struct list_head res_list; > }; > > -static int acpi_hotmem_initialized; > - > static acpi_status > acpi_memory_get_resource(struct acpi_resource *resource, void *context) > { > @@ -433,15 +431,6 @@ static int acpi_memory_device_add(struct acpi_device *device) > > printk(KERN_DEBUG "%s \n", acpi_device_name(device)); > > - /* > - * Early boot code has recognized memory area by EFI/E820. > - * If DSDT shows these memory devices on boot, hotplug is not necessary > - * for them. So, it just returns until completion of this driver's > - * start up. > - */ > - if (!acpi_hotmem_initialized) > - return 0; > - > if (!acpi_memory_check_device(mem_device)) { > /* call add_memory func */ > result = acpi_memory_enable_device(mem_device); > @@ -557,7 +546,6 @@ static int __init acpi_memory_device_init(void) > return -ENODEV; > } > > - acpi_hotmem_initialized = 1; > return 0; > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/