Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767947Ab2KONwK (ORCPT ); Thu, 15 Nov 2012 08:52:10 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:40425 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767891Ab2KONwI (ORCPT ); Thu, 15 Nov 2012 08:52:08 -0500 MIME-Version: 1.0 X-Originating-IP: [217.140.96.21] In-Reply-To: <1352973847-21605-2-git-send-email-lee.jones@linaro.org> References: <1352973847-21605-1-git-send-email-lee.jones@linaro.org> <1352973847-21605-2-git-send-email-lee.jones@linaro.org> Date: Thu, 15 Nov 2012 13:52:06 +0000 Message-ID: Subject: Re: [PATCH 1/2] Boottime: A tool for automatic measurement of kernel/bootloader boot time From: Andrew Murray To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@arm.linux.org.uk, linus.walleij@stericsson.com, jonas.aberg@stericsson.com, will.deacon@arm.com, arnd@arndb.de, Mian Yousaf Kaukab Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1452 Lines: 41 On 15 November 2012 10:04, Lee Jones wrote: > The overhead is very low and the results will be found under > sysfs/bootime, as well as detailed results in debugfs under > boottime/. The bootgraph* files are compatible with > scripts/bootgraph.pl. The reason for this patch is to provide > data (sysfs/boottime) suitable for automatic test-cases as > well as help for developers to reduce the boot time (debugfs). > > Based heavily on the original driver by Jonas Aaberg. > > + > +static LIST_HEAD(boottime_list); > +static DEFINE_SPINLOCK(boottime_list_lock); > +static struct boottime_timer boottime_timer; > +static int num_const_boottime_list; > +static struct boottime_list const_boottime_list[NUM_STATIC_BOOTTIME_ENTRIES]; > +static unsigned long time_kernel_done; > +static unsigned long time_bootloader_done; > +static bool system_up; > +static bool boottime_done; > + > +int __attribute__((weak)) boottime_arch_startup(void) > +{ > + return 0; > +} > + > +int __attribute__((weak)) boottime_bootloader_idle(void) > +{ > + return 0; > +} You may wish to use the __weak macro (include/linux/compiler*) instead of directly using GCC attributes here. Andrew Murray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/