Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1768158Ab2KOPPr (ORCPT ); Thu, 15 Nov 2012 10:15:47 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:41149 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1768107Ab2KOPPq (ORCPT ); Thu, 15 Nov 2012 10:15:46 -0500 Date: Thu, 15 Nov 2012 15:15:41 +0000 From: Lee Jones To: Linus Walleij Cc: Axel Lin , Patrice Chotard , Srinidhi Kasagar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/4] pinctrl: nomadik: Prevent NULL dereference if of_match_device returns NULL Message-ID: <20121115151541.GC14476@gmail.com> References: <1352955096.6793.1.camel@phoenix> <1352955365.6793.6.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 48 On Thu, 15 Nov 2012, Linus Walleij wrote: > On Thu, Nov 15, 2012 at 5:56 AM, Axel Lin wrote: > > > of_match_device() may return NULL. > > > > Signed-off-by: Axel Lin > > --- > > drivers/pinctrl/pinctrl-nomadik.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c > > index 238060e..40bd1b3 100644 > > --- a/drivers/pinctrl/pinctrl-nomadik.c > > +++ b/drivers/pinctrl/pinctrl-nomadik.c > > @@ -1863,9 +1863,14 @@ static int __devinit nmk_pinctrl_probe(struct platform_device *pdev) > > > > if (platid) > > version = platid->driver_data; > > - else if (np) > > - version = (unsigned int) > > - of_match_device(nmk_pinctrl_match, &pdev->dev)->data; > > + else if (np) { > > + const struct of_device_id *match; > > + > > + match = of_match_device(nmk_pinctrl_match, &pdev->dev); > > + if (!match) > > + return -ENODEV; > > + version = (unsigned int) match->data; > > + } > > AFAICT this can actually happen so patch applied, unless Lee > speaks against it. At the very least it make the code easy to read. Acked-by: Lee Jones -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/