MIME-Version: 1.0
In-Reply-To: <20121115204333.GJ11566@mwanda>
References: <1352496782-7246-1-git-send-email-yamanetoshi@gmail.com>
	<1352496836-7280-1-git-send-email-yamanetoshi@gmail.com>
	<20121114124110.GG11515@mwanda>
	<CAOTypNR_dDjg=XA-yP2OhyrLs3LEBPDFSRBORZUPh6Qzo4w8xA@mail.gmail.com>
	<20121115201817.GO11515@mwanda>
	<CAOTypNR3Wa1rpc45kG2W1Yv-6rXD==kxx+m9TC=94m08EefkoQ@mail.gmail.com>
	<20121115204333.GJ11566@mwanda>
Date: Fri, 16 Nov 2012 05:53:11 +0900
Message-ID: <CAOTypNTkeU03_gbA8CHAGR8QiF2JPgd=z4YMtd85_v+Zn4frQg@mail.gmail.com>
Subject: Re: [PATCH 2/4] staging/serqt_usb2: refactor qt_read_bulk_callback()
 in serqt_usb2.c
From: YAMANE Toshiaki <yamanetoshi@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, Mauro Carvalho Chehab <mchehab@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org,
        Alan Stern <stern@rowland.harvard.edu>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 874
Lines: 32

On Fri, Nov 16, 2012 at 5:43 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Btw:
>> +             dev_dbg(&port->dev, "Line status status.\n");
>                                      ^^^^^^^^^^^^^^^^^^^
> These kind of debug statements which just tell which function is
> being called can be deleted.  The function tracer already provides
> that information.

I did not know that. Thanks!

>> +             fn = ProcessLineStatus;
>> +     } else {
>> +             dev_dbg(&port->dev, "Modem status status.\n");
>> +             fn = ProcessModemStatus;
>
> regards,
> dan carpenter
>


-- 

Regards,

YAMANE Toshiaki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/