Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408Ab2KPIgI (ORCPT ); Fri, 16 Nov 2012 03:36:08 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:58021 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957Ab2KPIgH (ORCPT ); Fri, 16 Nov 2012 03:36:07 -0500 Message-ID: <50A5FAEB.7090202@gmail.com> Date: Fri, 16 Nov 2012 16:35:55 +0800 From: Shan Wei User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: jesse@nicira.com CC: Shan Wei , dev@openvswitch.org, NetDev , Kernel-Maillist , David Miller , cl@linux-foundation.org, Tejun Heo Subject: Re: [PATCH v4 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper References: <50A1A7D9.2040506@gmail.com> In-Reply-To: <50A1A7D9.2040506@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2406 Lines: 70 Shan Wei said, at 2012/11/13 9:52: > From: Shan Wei > > just use more faster this_cpu_ptr instead of per_cpu_ptr(p, smp_processor_id()); > > > Signed-off-by: Shan Wei > Reviewed-by: Christoph Lameter Jesse Gross, would you like to pick it up to your tree? > --- > no changes vs v3,v2. > --- > net/openvswitch/datapath.c | 4 ++-- > net/openvswitch/vport.c | 5 ++--- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c > index 4c4b62c..77d16a5 100644 > --- a/net/openvswitch/datapath.c > +++ b/net/openvswitch/datapath.c > @@ -208,7 +208,7 @@ void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb) > int error; > int key_len; > > - stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id()); > + stats = this_cpu_ptr(dp->stats_percpu); > > /* Extract flow from 'skb' into 'key'. */ > error = ovs_flow_extract(skb, p->port_no, &key, &key_len); > @@ -282,7 +282,7 @@ int ovs_dp_upcall(struct datapath *dp, struct sk_buff *skb, > return 0; > > err: > - stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id()); > + stats = this_cpu_ptr(dp->stats_percpu); > > u64_stats_update_begin(&stats->sync); > stats->n_lost++; > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c > index 03779e8..70af0be 100644 > --- a/net/openvswitch/vport.c > +++ b/net/openvswitch/vport.c > @@ -333,8 +333,7 @@ void ovs_vport_receive(struct vport *vport, struct sk_buff *skb) > { > struct vport_percpu_stats *stats; > > - stats = per_cpu_ptr(vport->percpu_stats, smp_processor_id()); > - > + stats = this_cpu_ptr(vport->percpu_stats); > u64_stats_update_begin(&stats->sync); > stats->rx_packets++; > stats->rx_bytes += skb->len; > @@ -359,7 +358,7 @@ int ovs_vport_send(struct vport *vport, struct sk_buff *skb) > if (likely(sent)) { > struct vport_percpu_stats *stats; > > - stats = per_cpu_ptr(vport->percpu_stats, smp_processor_id()); > + stats = this_cpu_ptr(vport->percpu_stats); > > u64_stats_update_begin(&stats->sync); > stats->tx_packets++; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/