Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752152Ab2KPQsV (ORCPT ); Fri, 16 Nov 2012 11:48:21 -0500 Received: from zoneX.GCU-Squad.org ([194.213.125.0]:39289 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043Ab2KPQsR (ORCPT ); Fri, 16 Nov 2012 11:48:17 -0500 Date: Fri, 16 Nov 2012 17:47:53 +0100 From: Jean Delvare To: Mika Westerberg Cc: "Rafael J. Wysocki" , ben-linux@fluff.org, w.sang@pengutronix.de, linux-kernel@vger.kernel.org, lenb@kernel.org, rafael.j.wysocki@intel.com, broonie@opensource.wolfsonmicro.com, grant.likely@secretlab.ca, linus.walleij@linaro.org, bhelgaas@google.com, mathias.nyman@linux.intel.com, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support Message-ID: <20121116174753.67d71043@endymion.delvare> In-Reply-To: <20121116152332.GV17774@intel.com> References: <1352977397-2280-1-git-send-email-mika.westerberg@linux.intel.com> <2439178.tCj2rUMYJS@vostro.rjw.lan> <20121116140357.5e0a6d6b@endymion.delvare> <1499062.QDd9DGofy9@vostro.rjw.lan> <20121116144256.55b49cae@endymion.delvare> <20121116141729.GS17774@intel.com> <20121116152332.GV17774@intel.com> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 903 Lines: 29 Hi Mika, On Fri, 16 Nov 2012 17:23:32 +0200, Mika Westerberg wrote: > Here's the updated version where we handle 10-bit addresses properly > (hopefully). > (...) > +static int acpi_i2c_find_device(struct device *dev, acpi_handle *handle) > +{ > (...) > + memset(&i2c_find, 0, sizeof(i2c_find)); > + i2c_find.addr = client->addr; > + if (client->flags & I2C_CLIENT_TEN) > + i2c_find.access_mode = ACPI_I2C_10BIT_MODE; This works because you are lucky and ACPI_I2C_7BIT_MODE has value 0, but for correctness I'd rather add: else i2c_find.access_mode = ACPI_I2C_7BIT_MODE; Other than this the new code looks OK WRT this issue, thanks. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/