Date: Fri, 16 Nov 2012 21:16:55 +0100
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Alban Bedel <alban.bedel@avionic-design.de>
Cc: linux-kernel@vger.kernel.org, Roland Stigge <stigge@antcom.de>,
        Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Subject: Re: [PATCH 2/3] pwm: lpc32xx - Properly disable the clock on device
 remove
Message-ID: <20121116201655.GA24790@avionic-0098.mockup.avionic-design.de>
References: <1352894295-14339-1-git-send-email-alban.bedel@avionic-design.de>
 <1352894295-14339-3-git-send-email-alban.bedel@avionic-design.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP"
Content-Disposition: inline
In-Reply-To: <1352894295-14339-3-git-send-email-alban.bedel@avionic-design.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1659
Lines: 49


--jRHKVT23PllUwdXP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 14, 2012 at 12:58:14PM +0100, Alban Bedel wrote:
[...]
>  static int __devexit lpc32xx_pwm_remove(struct platform_device *pdev)
>  {
>  	struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev);
> +	int i;

This should rather be unsigned int since pwm_chip.npwm is unsigned as
well.

> +
> +	for (i = 0 ; i < lpc32xx->chip.npwm ; i += 1)

No space before ';' and "i++" please.

Thierry

--jRHKVT23PllUwdXP
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBAgAGBQJQpp83AAoJEN0jrNd/PrOhQUEP/1duOw1H8KKgrEYzXxXMuoUC
wr62vqjJMGvZvPvhMdsf4IQOZX4iHI4si8vck8V1XTFW5VlMFUQ5lsgW2l6KdTuk
6SB+GIDH640kZINsphxx7OPEE0S33/MfnlLLdSk1GD09HRdbGH8DAuKMLvgjzxFV
70A9hycdbtx3bTkIRmlfyE+7SBTlAjYr4WA/bRWPFejYljTVnBD5/y1yDr/duJLk
pgK3ikAHE5xFFNGFrG8WM0Vnh8iUfzca2+PxMpmqJB1VDL9dUdJCV5bmz2GLf6KK
2EnJ+xG5XmJB9DKnmKDRxfkAszwpwj91skDloyNIJ/xYcDfuN+wh3Ut7pbUhGdEM
Zt7kkHPOELzWJprKV51PB8D7TuWzyqndfYdV3VqOBusFv7NGOWp537v2Ya/eEBAa
0INF8ndou0zGNHWOnSwqxLVh8nsXDGmWnLOyI+QxawLHLeo8xjW6h1eDc9oOyaU1
5FkfOlBCrgvgs+I3z7hqojZWJ8lRNL0TFUbcKX7efTHTHiTWh95Y1sPESG+iQDf1
D4+pBjMix/n4RNaBw+y986ljiQEDjzb4L2lhatsd36Y9bd7kYkhx8WbE3GLTQ0Vc
qSma6VRvB1STs8WGsBRPVIATa9w3Y5juL73U69GyyWX4nAEchnXnVvmE8WSZsIww
qmbP00M3GLlTYfdDiVZ+
=jozb
-----END PGP SIGNATURE-----

--jRHKVT23PllUwdXP--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/