Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015Ab2KQPbO (ORCPT ); Sat, 17 Nov 2012 10:31:14 -0500 Received: from mail.skyhub.de ([78.46.96.112]:51735 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751881Ab2KQPbN (ORCPT ); Sat, 17 Nov 2012 10:31:13 -0500 Date: Sat, 17 Nov 2012 16:31:27 +0100 From: Borislav Petkov To: Henrique de Moraes Holschuh Cc: Gene Heskett , Boris Ostrovsky , hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de, herrmann.der.user@googlemail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86, microcode, AMD: Add support for family 16h processors Message-ID: <20121117153127.GA30471@x1.osrc.amd.com> Mail-Followup-To: Borislav Petkov , Henrique de Moraes Holschuh , Gene Heskett , Boris Ostrovsky , hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de, herrmann.der.user@googlemail.com, linux-kernel@vger.kernel.org References: <1353004910-2204-1-git-send-email-boris.ostrovsky@amd.com> <20121115204503.GB18032@khazad-dum.debian.net> <201211151801.23160.gheskett@wdtv.com> <50A57C35.10906@amd.com> <20121117144117.GD16441@x1.osrc.amd.com> <20121117152918.GA16697@khazad-dum.debian.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20121117152918.GA16697@khazad-dum.debian.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 30 On Sat, Nov 17, 2012 at 01:29:19PM -0200, Henrique de Moraes Holschuh wrote: > On Sat, 17 Nov 2012, Borislav Petkov wrote: > > On Thu, Nov 15, 2012 at 06:35:17PM -0500, Boris Ostrovsky wrote: > > > One possibility is that BIOS already incorporated all patches (which > > > typically is the case) and so the driver doesn't have to do anything. > > > > /proc/cpuinfo contains ucode version and the processor's f/m/s, which > > is enough information to tell us whether your old phenom needs ucode > > patching. > > Maybe, however F/M/S information is incomplete, not to mention trying to > rebuild the proper processor signature from it is anything but > forward-proof. For Intel, it is also useless, you also need the processor > flags... > > If /proc/cpuinfo is to be useful for microcode purposes, it should add a > microcode signature line, with CPUID(1).EAX, and on Intel processors, also a > second parameter with the processor flags mask (I don't know if AMD needs > something else other than CPUID(1).EAX). I was speaking only about that particular case of Gene's AMD CPU. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/