Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505Ab2KRTDh (ORCPT ); Sun, 18 Nov 2012 14:03:37 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:51839 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142Ab2KRTDg (ORCPT ); Sun, 18 Nov 2012 14:03:36 -0500 Date: Sun, 18 Nov 2012 14:03:32 -0500 (EST) Message-Id: <20121118.140332.1273544560009594278.davem@davemloft.net> To: torvalds@linux-foundation.org Cc: viro@zeniv.linux.org.uk, monstr@monstr.eu, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: sigaltstack fun From: David Miller In-Reply-To: References: <20121118054510.GE16916@ZenIV.linux.org.uk> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1378 Lines: 32 From: Linus Torvalds Date: Sun, 18 Nov 2012 08:45:43 -1000 > On Sat, Nov 17, 2012 at 7:45 PM, Al Viro wrote: >> >> Linus, do you have any objections to the above? FWIW, I've a tentative >> patchset in that direction (most of it from the last cycle); right now >> it + stuff currently in signal.git#for-next is at -3.4KLoC and I hadn't >> dealt with the biarch side of things yet... > > I have absolutely no objections. sigaltstack has always been kind of > messy, and made worse by the fact that it gets effectively no testing > (because it's generally not used by normal code and even code that > uses it tends to use it only for very uncommon events). So forcing all > the sigaltstack code into generic code and at least avoiding the > "different architectures can get things subtly - or not so subtly - > wrong in different ways" sounds like a good thing. FWIW, if folks are looking for testcases there are a small number in glibc, a quick grep shows: nptl/tst-cancel20.c nptl/tst-cancel21.c nptl/tst-signal6.c debug/tst-longjmp_chk2.c LTP probably has a bunch too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/