Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753092Ab2KSHrQ (ORCPT ); Mon, 19 Nov 2012 02:47:16 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:51815 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932Ab2KSHrP (ORCPT ); Mon, 19 Nov 2012 02:47:15 -0500 MIME-Version: 1.0 X-Originating-IP: [85.250.20.247] In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A1D4191@SHSMSX101.ccr.corp.intel.com> References: <1353070447.15558.1681.camel@cliu38-desktop-build> <27240C0AC20F114CBF8149A2696CBE4A1D4191@SHSMSX101.ccr.corp.intel.com> From: Ohad Ben-Cohen Date: Mon, 19 Nov 2012 09:46:54 +0200 Message-ID: Subject: Re: [PATCH] mmc,sdio: Fix the panic due to devname NULL when calling pm_runtime_set_active() To: "Liu, Chuansheng" Cc: Chris Ball , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 781 Lines: 20 On Mon, Nov 19, 2012 at 7:57 AM, Liu, Chuansheng wrote: > Rechecked these codes, the trace event runtime_pm_status is added newly, this is different with vanilla > Linux. Not sure I'm following - can you point out which tree are you working with ? > So I still think that calling pm_runtime_set_active is not safe when dev_name is NULL. > If you agree this point, I can refine the code that moving "init the dev_name " from mmc_add_card > to mmc_sdio_init_card. This sounds more reasonable. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/