Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752914Ab2KTIcn (ORCPT ); Tue, 20 Nov 2012 03:32:43 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:28097 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514Ab2KTIcl (ORCPT ); Tue, 20 Nov 2012 03:32:41 -0500 From: Glauber Costa To: Cc: , Peter Zijlstra , Paul Turner , Balbir Singh , Tejun Heo , , Glauber Costa , Mike Galbraith , Thomas Gleixner Subject: [PATCH 1/6] don't call cpuacct_charge in stop_task.c Date: Tue, 20 Nov 2012 12:31:59 +0400 Message-Id: <1353400324-10897-2-git-send-email-glommer@parallels.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1353400324-10897-1-git-send-email-glommer@parallels.com> References: <1353400324-10897-1-git-send-email-glommer@parallels.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 35 Commit 8f618968 changed stop_task to do the same bookkeping as the other classes. However, the call to cpuacct_charge() doesn't affect the scheduler decisions at all, and doesn't need to be moved over. Moreover, being a kthread, the migration thread won't belong to any cgroup anyway, rendering this call quite useless. Signed-off-by: Glauber Costa CC: Mike Galbraith CC: Peter Zijlstra CC: Thomas Gleixner --- kernel/sched/stop_task.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/sched/stop_task.c b/kernel/sched/stop_task.c index da5eb5b..fda1cbe 100644 --- a/kernel/sched/stop_task.c +++ b/kernel/sched/stop_task.c @@ -68,7 +68,6 @@ static void put_prev_task_stop(struct rq *rq, struct task_struct *prev) account_group_exec_runtime(curr, delta_exec); curr->se.exec_start = rq->clock_task; - cpuacct_charge(curr, delta_exec); } static void task_tick_stop(struct rq *rq, struct task_struct *curr, int queued) -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/