Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238Ab2KTJkJ (ORCPT ); Tue, 20 Nov 2012 04:40:09 -0500 Received: from mail-ia0-f174.google.com ([209.85.210.174]:49862 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582Ab2KTJkH (ORCPT ); Tue, 20 Nov 2012 04:40:07 -0500 MIME-Version: 1.0 In-Reply-To: <20121120093242.GK3290@n2100.arm.linux.org.uk> References: <1353403339-11679-1-git-send-email-dmitry.torokhov@gmail.com> <1353403339-11679-2-git-send-email-dmitry.torokhov@gmail.com> <20121120093242.GK3290@n2100.arm.linux.org.uk> Date: Tue, 20 Nov 2012 15:10:06 +0530 Message-ID: Subject: Re: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare() From: Viresh Kumar To: Russell King - ARM Linux Cc: Dmitry Torokhov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mike Turquette Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 32 On 20 November 2012 15:02, Russell King - ARM Linux wrote: > On Tue, Nov 20, 2012 at 01:22:17AM -0800, Dmitry Torokhov wrote: >> We'll need to invoke clk_unprepare() via a pointer in our devm_* >> conversion so let's uninline the pair. > > NAK. This breaks non-common clock using implementations. Hi Russell, Dummy routines for non-common clock are still there. Sorry, couldn't get why this will break those platforms: +static inline int clk_prepare(struct clk *clk) +{ + might_sleep(); + return 0; +} + +static inline void clk_unprepare(struct clk *clk) +{ + might_sleep(); +} + -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/