From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Sachin Kamat'" <sachin.kamat@linaro.org>, linux-kernel@vger.kernel.org
Cc: linus.walleij@linaro.org, patches@linaro.org
References: <1353300961-22632-1-git-send-email-sachin.kamat@linaro.org>
In-reply-to: <1353300961-22632-1-git-send-email-sachin.kamat@linaro.org>
Subject: RE: [PATCH 1/1] pinctrl: Samsung: Do not initialise statics to 0
Date: Tue, 20 Nov 2012 20:49:19 +0900
Message-id: <0c8a01cdc715$1312c410$39384c30$%kim@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: Ac3GEwe7xGUJWj8aTxycVDMrdoC0XQBAem7w
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1328
Lines: 48

Sachin Kamat wrote:
> 
> Static variables are initialised to 0 by GCC.
> Fixes the following checkpatch error:
> ERROR: do not initialise statics to 0 or NULL
> FILE: pinctrl/pinctrl-samsung.c:50:
> static unsigned int pin_base = 0;
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/pinctrl/pinctrl-samsung.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-
> samsung.c
> index 81c9896..36f8875 100644
> --- a/drivers/pinctrl/pinctrl-samsung.c
> +++ b/drivers/pinctrl/pinctrl-samsung.c
> @@ -47,7 +47,7 @@ struct pin_config {
>  	{ "samsung,pin-pud-pdn", PINCFG_TYPE_PUD_PDN },
>  };
> 
> -static unsigned int pin_base = 0;
> +static unsigned int pin_base;
> 
>  static inline struct samsung_pin_bank *gc_to_pin_bank(struct gpio_chip
> *gc)
>  {
> --
> 1.7.4.1

Looks OK to me.

Linus, can I pick this up in my tree?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/